isky/backend-springboot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

solved logic error

Browse Source
This commit is contained in:
heyethereum
2024-08-17 15:20:03 +08:00
parent 0716214a31
commit b8ee29ce9a
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/com/safeqr/app/qrcode/service/SMSVerificationService.java
View File

@@ -99,13 +99,17 @@ public class SMSVerificationService {
if (lowerCaseSms.contains(keyword)) {
logger.info("Phishing keyword detected: {}", keyword);
smsEntity.setKeywordDetected("Potential Phishing - " + category);
return CLASSIFY_WARNING;
return checkPhoneNumber(smsEntity.getPhone()).equals(CLASSIFY_WARNING) ?
CLASSIFY_WARNING :
CLASSIFY_UNSAFE;
}
}
}
// If no phishing keywords are found, sent for local phone number checks
return checkPhoneNumber(smsEntity.getPhone());
return checkPhoneNumber(smsEntity.getPhone()).equals(CLASSIFY_UNSAFE) ?
CLASSIFY_WARNING :
CLASSIFY_SAFE;
}
private String checkPhoneNumber(String phoneNumber) {
@@ -121,7 +125,7 @@ public class SMSVerificationService {
// Check if it's a valid Singapore mobile or landline number
if (phoneNumber.matches("^[689]\\d{7}$") && (phoneNumber.startsWith("8") || phoneNumber.startsWith("9"))) {
return CLASSIFY_SAFE;
return CLASSIFY_WARNING;
}
// If it doesn't match mobile